Skip to content

London | 26-March-SDC | Ammad Ur Rehman | Sprint 1 | Individual Shell Tools#420

Open
anosidium wants to merge 13 commits into
CodeYourFuture:mainfrom
anosidium:individual-shell-tools
Open

London | 26-March-SDC | Ammad Ur Rehman | Sprint 1 | Individual Shell Tools#420
anosidium wants to merge 13 commits into
CodeYourFuture:mainfrom
anosidium:individual-shell-tools

Conversation

@anosidium

@anosidium anosidium commented Mar 23, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Done all the required exercise with some stretch exercises completed

Questions

I find reading the manual pages of the commands confusing and looking them up on the internet isn’t much better either.

@anosidium anosidium added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 23, 2026
SlideGauge
SlideGauge reviewed Apr 17, 2026
View reviewed changes

@SlideGauge SlideGauge left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you adjust the settings of your editor and adjust all the scripts, they are missing the trailing new line

Comment thread individual-shell-tools/awk/script-04.sh Outdated
Comment thread individual-shell-tools/grep/script-01.sh Outdated
Comment thread individual-shell-tools/grep/script-06.sh Outdated
Comment thread individual-shell-tools/sed/script-06.sh Outdated
Comment thread individual-shell-tools/ls/script-04.sh
Comment thread individual-shell-tools/cat/script-02.sh Outdated
@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 17, 2026
@anosidium

anosidium commented May 12, 2026

Copy link
Copy Markdown
Author

Could you adjust the settings of your editor and adjust all the scripts, they are missing the trailing new line

Thanks for the review. Before I address the rest of your comments, could you tell me a bit more about how to do this? Are you referring to the “No newline at end of file”?

My other pull requests have had the same thing, so this is the first time I’ve heard it mentioned.

@SlideGauge

SlideGauge commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Yeah, I'm talking about
image
sign you have in github. The setting itself depends on the editor you use, this is an example how you do this in the VS code:
https://stackoverflow.com/questions/44704968/visual-studio-code-insert-newline-at-the-end-of-files

@anosidium anosidium added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 12, 2026
@anosidium

anosidium commented Jun 12, 2026

Copy link
Copy Markdown
Author

Thanks for the review, I've amended my solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SlideGauge SlideGauge SlideGauge left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anosidium @SlideGauge